Closed
Bug 666574
Opened 13 years ago
Closed 13 years ago
Advanced pref pane shouldn't use setBoolPref
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
Firefox 7
People
(Reporter: steffen.wilberg, Assigned: steffen.wilberg)
References
Details
Attachments
(1 file)
|
3.26 KB,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
The prefwindow doesn't need to hack around with setBoolPref. setBoolPref applies instantly, which is wrong on Windows. Use <preference>.value instead.
|
Assignee | |
Comment 1•13 years ago
|
||
The invertion of !pref.value is now done by the preference element's inverted="true".
Attachment #541363 -
Flags: review?(mano)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 541363 [details] [diff] [review] patch r=mano
Attachment #541363 -
Flags: review?(mano) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/28e4374838c4
Whiteboard: [inbound]
|
||
Comment 4•13 years ago
|
||
Merged: http://hg.mozilla.org/mozilla-central/rev/28e4374838c4
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
OS: Windows 7 → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7
You need to log in
before you can comment on or make changes to this bug.
Description
•