666666 - Reflect HTMLMediaElement.preload like an enumerated attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 541440 [details] [diff] [review]
Patch v1

r=me

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Yay 666666 !!!!!!

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 541440 [details] [diff] [review]
Patch v1

Review of attachment 541440 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/html/content/test/test_bug660663.html
@@ +29,5 @@
> +                         []);
> +reflectLimitedEnumerated(document.createElement("audio"),
> +                         "preload",
> +                         ["none", "metadata", "auto"],
> +                         []);

I think that would be a better idea to create a new file instead of adding these tests here. If you want to create a test suite for attribute reflection, splitting it by element would probably be better than doing that in the same file.

Not critical, though.

Comment 4

[Mounir Lamouri (:mounir)]

Oh, and thank you very much for fixing that :)

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/e00f235a80e4

Comment 6

[Jean-Yves Perrier [:teoli]]

The https://developer.mozilla.org/en/DOM/HTMLMediaElement document is up-to-date regarding this change (I fixed a small typo and the type).

I added a sentence to Firefox 8 for developers, too.