Closed
Bug 666938
Opened 13 years ago
Closed 13 years ago
No warning when Binary XPCOMs fail loading due to Module::kVersion
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: jerry, Assigned: benjamin)
Details
Attachments
(1 file)
5.53 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_8; en-us) AppleWebKit/533.21.1 (KHTML, like Gecko) Version/5.0.5 Safari/533.21.1 Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20100101 Firefox/5.0 Starting with Firefox 5.0, binary XPCOM components must have exactly the correct Module::kVersion or they will not load. Since this will happen with any extension containing such a component that has not been updated recently, this should not be a silent failure. There should be at least a warning printed to the system stderr or Firefox' Error Console Reproducible: Always Steps to Reproduce: 1. Install an older Firefox extension containing a Binary XPCOM Component into Firefox 5. 2. Launch Firefox 5 and do whatever is needed to load the extension. Actual Results: Error console prints only a warning saying that the XPCOM Component is undefined. Expected Results: Error console, and probably system's stderr, should instead print a warning explaining that there was a mismatch in Module::kVersion, giving the required kVersion and the found kVersion, with a recovery suggestion to update the extension and a link to the documentation further explaining the issue. For more information, see this bug https://bugzilla.mozilla.org/show_bug.cgi?id=656331
Updated•13 years ago
|
Component: Extension Compatibility → XPCOM
Product: Firefox → Core
QA Contact: extension.compatibility → xpcom
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → benjamin
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #541725 -
Flags: review?(dtownsend)
Updated•13 years ago
|
Attachment #541725 -
Flags: review?(dtownsend) → review+
Comment 2•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3b245f7f94d7
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•