667295 - Enable JavaScript Shell packaging only when js executable is generated

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Takanori MATSUURA]

When firefox is built on top of xulrunner, no js executable is generated during building firefox. So we should generate jsshell zip package only when js executable is generated.

And NSPR libraries are not generated when --enable-system-nspr is set. So we should add NSPR libraries only when internal NSPR is built.

Comment 1

[Takanori MATSUURA]

Attachment: Generate JavaScript Shell packag only when js executable is generated

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 542024 [details] [diff] [review]
Generate JavaScript Shell packag only when js executable is generated

Review of attachment 542024 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. I thought there might be some situation where this would break, but I couldn't think of it while reviewing the original patch.

Comment 3

[(not currently active) Ted Mielczarek]

Pushed to b-s:
http://hg.mozilla.org/projects/build-system/rev/bf88ac3f2316

Takanori, thanks for the patch! In the future, could you put the bug number in the changeset description? That way when someone pushes your patch for you they don't need to edit anything, they can just import it and push it.

Comment 4

[Takanori MATSUURA]

Ted,
Thank you for letting me know.
I'll carefully check the changeset description next time.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/bf88ac3f2316