667385 - nshttppipeline::isdone wrong

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

pipeline defines isdone() as when the req and resp q is empty.. but it is really when the req and resp q's contain only nshttptransactions which are isDone()..

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: v1

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 542095 [details] [diff] [review]
v1

Review of attachment 542095 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

Comment 3

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/639b9381a808

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 542095 [details] [diff] [review]
v1

Review of attachment 542095 [details] [diff] [review]:
-----------------------------------------------------------------

sr=honzab with please do a followup commit:
- change PRBool to bool / PR_TRUE to true

Up to you:
- i++ -> ++i
- check for result of call to Response()/Request(), but that would mean something really broken that would show up in other places of the code first, so it is OK

Comment 5

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/97334042d500

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/97334042d500

Comment 7

[Ed Morley [:emorley]]

And the main landing:
https://hg.mozilla.org/mozilla-central/rev/639b9381a808