667887 - Implement nsMappedAttributes::SizeOf()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 1

[Boris Zbarsky [:bzbarsky]]

This is wrong.  Mapped attributes are shared across elements, so adding them to the size of mAttrsAndChildren is wrong.  You want to add them to the size of the document itself, by going through the HTML stylesheet.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch v2

This patch tries to take into account Boris comment.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 542636 [details] [diff] [review]
Patch v2

So this sets the size to:

 sizeof(nsMappedAttributes) + mAttrCount * (sizeof(void*) + sizeof(InternalAttr))

This looks wrong.  The correct size of an nsMappedAttributes, from |nsMappedAttributes::operator new| is:

  sizeof(nsMappedAttributes) - sizeof(void*) + mBufferSize*sizeof(InternalAttr)

In particular, nsMappedAttributes allocates all its storage for InternalAttr structs inline.  Now your first problem is that mBufferSize is debug-only....

I wonder whether using mAttrCount in practice is ok because we never have long-lived nsMappedAttributes for mAttrCount != mBufferSize.

Comment 4

[Mounir Lamouri (:mounir)]

Attachment: Patch v3

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 543969 [details] [diff] [review]
Patch v3

Can you add an assert that mAttrCount == mBufferSize in SizeOf?  If that ever fails to be true, we want to know.

r=me with that.

Comment 6

[Marco Bonardo [:mak]]

this has been backed out by ehsan due to bustage with all the other changesets in the same push

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/a3b60c8ebad3