668192 - Improve screen reader reading of password manager intro text

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Marco Zehe (:MarcoZ)]

Attachment: Proposed less intrusive patch

Currently, the xul:description element is set to control the password tree, which on the screen reader side turns the text into the accDescription, which is additional info, not primary information.

In order for screen readers to better read the text,
a) the control attribute should be removed from xul:description, and an aria-labelledby attribute added to the xul:tree element.
or
b) the xul:description element should be turned into a xul:label element.

I'm attaching a patch for solution a). If reviewers think we should go with b) instead, which might introduce other differences which might not be desired on the visual side, I can attach a patch to that effect, too.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Alternative patch

This changes xul:description to xul:label. Note that I have no way of verifying visually whether this makes any difference for sighted users. This looks less intrusive, but is actually changing an element, but I'm proposing it anyway.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 542786 [details] [diff] [review]
Alternative patch

This change looks fine. It does not regress bug 482232.

Comment 3

[Marco Zehe (:MarcoZ)]

Landed: http://hg.mozilla.org/mozilla-central/rev/5fcda42e70bd