668469 - "Assertion failure in -[mozRootAccessible didReceiveFocus]" "trying to set focus to ignored element"

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Build Firefox with --enable-accessibility.
2. Enable accessibility, e.g. by pasting the following into the js console:

Components.classes["@mozilla.org/accessibilityService;1"]
      .getService(Components.interfaces.nsIAccessibleRetrieval);

3. Load the testcase.
4. Click the button.

Result:

2011-06-30 01:59:27.785 firefox-bin[55214:903] *** Assertion failure in -[mozRootAccessible didReceiveFocus], /Users/jruderman/trees/mozilla-central/accessible/src/mac/mozAccessible.mm:582

2011-06-30 01:59:27.786 firefox-bin[55214:903] Mozilla has caught an Obj-C exception [NSInternalInconsistencyException: trying to set focus to ignored element! ((0x129cb4b10) AXUnknown)]

"Regression" from bug 524775.

This assertion is also mentioned in bug 450531, fwiw.

Comment 1

[Hubert Figuiere [:hub]]

I can't reproduce this on my tree....

Comment 2

[Jesse Ruderman]

Still happens for me, using a debug build from Tinderbox on Mac OS X 10.6.

Comment 3

[Hubert Figuiere [:hub]]

(In reply to Jesse Ruderman from comment #2)
> Still happens for me, using a debug build from Tinderbox on Mac OS X 10.6.

Which tinderbox build? One that does enable a11y or the regular one (that has it disabled)?

Comment 4

[Jesse Ruderman]

I can reproduce with the build in https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-macosx64-debug/1323730278/, for example. It's built with --enable-accessibility.  (IIRC, the "regular" Mac debug builds have accessibility enabled iff they are 64-bit builds.)

Comment 5

[Hubert Figuiere [:hub]]

Even with that built I can't reproduce...

Comment 6

[Hubert Figuiere [:hub]]

I have gotten that with DOM Inspector.

Comment 7

[Hubert Figuiere [:hub]]

Unlike I said in comment 5 I completely can reproduce with the test case.

Comment 9

[Hubert Figuiere [:hub]]

Attachment: Don't ignore focusable elements. r=

Comment 10

[Hubert Figuiere [:hub]]

Comment on attachment 654200 [details] [diff] [review]
Don't ignore focusable elements. r=

This is as proposed in bug 761574

Comment 11

[alexander :surkov (:asurkov)]

Comment on attachment 654200 [details] [diff] [review]
Don't ignore focusable elements. r=

Review of attachment 654200 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thank you

::: accessible/src/mac/mozAccessible.mm
@@ +101,5 @@
>  
>    // unknown (either unimplemented, or irrelevant) elements are marked as ignored
>    // as well as expired elements.
> +  return !mGeckoAccessible || ([[self role] isEqualToString:NSAccessibilityUnknownRole] &&
> +                               !(mGeckoAccessible->State() & states::FOCUSABLE));

use NativeInteractiveState

Comment 12

[Hubert Figuiere [:hub]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/269195e72bf9

Comment 13

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Backed out because it landed on a burning tree

https://hg.mozilla.org/integration/mozilla-inbound/rev/46365c62935c

Comment 14

[Hubert Figuiere [:hub]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7055bd788274

Comment 15

[alexander :surkov (:asurkov)]

Hub, sorry to say that, but InteractiveState should be used instead, otherwise aria-descendant logic which affects on focusable state is ignored.

Comment 16

[Hubert Figuiere [:hub]]

ok, I'll fix it.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7055bd788274

Comment 18

[Hubert Figuiere [:hub]]

Attachment: Part 2: use InteractiveState() instead of NativeInteractiveState().

Comment 19

[alexander :surkov (:asurkov)]

Comment on attachment 655261 [details] [diff] [review]
Part 2: use InteractiveState() instead of NativeInteractiveState().

Review of attachment 655261 [details] [diff] [review]:
-----------------------------------------------------------------

you don't really need review for this

Comment 20

[Hubert Figuiere [:hub]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0b399d43b570

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0b399d43b570