Closed Bug 668661 Opened 13 years ago Closed 13 years ago

Incorrect detection of SeaMonkey version by Compatibility Center site

Categories

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: tonymec, Unassigned)

References

()

Details

(Keywords: polish, ue)

Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110630 Firefox/7.0a1 SeaMonkey/2.4a1 ID:20110630003039

When I view https://addons.mozilla.org/en-US/seamonkey/compatibility/ (and its subpages) with this version of SeaMonkey, it constantly talks about "SeaMonkey 5.0", e.g. twice on the homepage of the site:

<quote>
SeaMonkey 5.0
Add-on Compatibility Center

Be prepared for the release of SeaMonkey 5.0 with the tools and information available for the SeaMonkey Add-ons community found below.
</quote>

as if "SeaMonkey 5" was the next release. But it isn't! It is SeaMonkey 2.2, which will be based on Toolkit 5 and Gecko 5 (but what do rank-and-file users care about Gecko and Toolkit versions anyway?)
Can someone please refer me to the code/repository that creates those pages so that I can check whether I can come up with a patch? Thanks.
They are being replaced in bug 675807 so you probably aren't getting much traction here with devs.  You should check if the new URLs (see that bug) do what you want.
(In reply to comment #2)
> They are being replaced in bug 675807 so you probably aren't getting much
> traction here with devs.  You should check if the new URLs (see that bug) do
> what you want.

Not yet. Both of the following:
https://addons.allizom.org/z/en-US/thunderbird/compatibility/8.0
https://addons.allizom.org/z/en-US/seamonkey/compatibility/2.5
as well as their "old" versions (without /z) answer with "We’re sorry, but we can’t find what you’re looking for."
Without the version number, and without z/, the behaviour is still as in comment #0 (talking about Thunderbird 5 or Firefox 5, which is expected, but also about SeaMonkey 5, which looks weird). (With z/ and without the version it's the same sorry-can't-find error message for Tb & Sm as above.)

Let's see how it will be after bug 675807 gets FIXED; my little finger tells me that that bug will need a followup.
(In reply to comment #3)
> (In reply to comment #2)
> > They are being replaced in bug 675807 so you probably aren't getting much
> > traction here with devs.  You should check if the new URLs (see that bug) do
> > what you want.
> 
> Not yet. Both of the following:
> https://addons.allizom.org/z/en-US/thunderbird/compatibility/8.0
> https://addons.allizom.org/z/en-US/seamonkey/compatibility/2.5

What versions of thunderbird and seamonkey should show up? This is what controls the list: https://github.com/jbalogh/zamboni/blob/41d90c/settings.py#L1009
(In reply to comment #4)
> What versions of thunderbird and seamonkey should show up? This is what
> controls the list:
> https://github.com/jbalogh/zamboni/blob/41d90c/settings.py#L1009

Starting with version 5.0, TB should be like FF (with 3.1 being the version prior to 5.0). The current default should be 6.0.

For SM it's 2.1 through 2.5, with 2.0 being the version prior to 2.1. The current default should be 2.3.

In sum:
TB: 8.0 7.0 _6.0_ 5.0 3.1
SM: 2.5 2.4 _2.3_ 2.2 2.1
https://github.com/jbalogh/zamboni/commit/6b6a6b5 

I added a thunderbird and seamonkey version to make sure it works. The original bug is fixed since that was displaying results for firefox 5.0 but injecting seamonkey into the strings.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
https://addons.allizom.org/en-US/seamonkey/compatibility/ now resends to https://addons.allizom.org/en-US/seamonkey/compatibility/2.3 where BTW he results are even more one-sided than for Firefox (Adblock Plus getting here a whopping 22.6% of users, nothing else above 5%, and only 7 others above 1%).

I'm setting this to VERIFIED on the assumption that nothing can prevent the fix to propagate from allizom to mozilla (where ATM it isn't yet visible). Please REOPEN if for some reason the fix canNOT be propagated.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.