669108 - Public crash reports should display TotalVirtualMemory, AvailableVirtualMemory, SystemMemoryUsePercentage, AvailablePageFile, and AvailablePhysicalMemory

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Jonathan Watt [:jwatt]]

Right now to get information on the memory use (the fields TotalVirtualMemory, AvailableVirtualMemory and SystemMemoryUsePercentage...on Mac at least) at the time of a crash you need someone with admin access to crash-stats.mozilla.com to get that for you. This info should just be available on the public reports.

If someone can point me to the parts of the code that need patched I'd be happy to have a go at fixing this.

Comment 1

[Robert Kaiser]

There must be a reason, probably privacy or security concerns, why we hide those right now. Is there such a risk with that data? How large is it?

Comment 2

[(not currently active) Ted Mielczarek]

I don't believe there's any reason, there's no privacy risk to exposing this data AFAICT. I think we just treat all data from the client as private-by-default unless we explicitly make it public in the Socorro code.

Comment 3

[Benjamin Smedberg]

Also please publicly report the field "OOMAllocationSize", which I just added in bug 716638. It will not be present in all reports.

Comment 4

[Benjamin Smedberg]

Laura, this looks relatively easy and would be a big win for a bunch of people looking at our OOM crashes and bugs, is it possible to get this prioritized?

Comment 5

[Justin Lebar (not reading bugmail)]

While we're piling on here, it would be great to get AvailablePageFile and AvailablePhysicalMemory (bug 720444) added as well.

Comment 6

[Justin Lebar (not reading bugmail)]

Unless we're concerned about fingerprinting on Available{PhysicalMemory,PageFile}?  It seems that you'd be able to fingerprint much better with e.g. the list of add-ons.

Comment 7

[Laura Thomson :laura]

Lars, I don't think we have those in the processed json so you'll need to make a processor change first.

Comment 8

[Laura Thomson :laura]

We need to get access to the the raw json in the UI to solve this.

Comment 9

[Laura Thomson :laura]

pull request https://github.com/mozilla/socorro/pull/333

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/8735569798967b0b91898ee7b4b8e3ab542aa63b
Bug 669108 - forgot OOMAllocationSize  added here

https://github.com/mozilla/socorro/commit/49b4bdad598df7ff9a899c9d3cc3abfbcaf289f1
Merge pull request #333 from lauraxt/669108

Fixes bug 669108, add some more stuff from the raw JSON to the UI.  Also added better error checking.

Comment 11

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

Thank you mightily :rhelmer for submitting a crash to stage for verification purposes.
https://crash-stats.allizom.org/report/index/8331e757-0eee-43ba-9ad8-037c52120210


Bumping to QA verified on stage. The following fields are no present on crash reports:

TotalVirtualMemory
AvailableVirtualMemory
SystemMemoryUsePercentage
AvailablePageFile
AvailablePhysicalMemory
OOMAllocationSize

Comment 12

[Austin Davis [:austind]]

Yes, TotalVirtualMemory, AvailableVirtualMemory, SystemMemoryUsePerce are now visible on crash reports.

Comment 13

[(not currently active) Ted Mielczarek]

We should probably get a followup to format these better, or at least add units. (They're all bytes, except for System Memory Use Percentage, which is obviously a percentage.)