669722 - update-verify-bump.pl incorrectly removes the previous release when oldVersion=5.0

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

We check the first line of an update verify to see if we need to remove the previous version before bumping. The first line is a comment with the version of previous release. This all worked fine until recently, when we've stopped using the "rc" moniker in version numbers. Now, when this comparison happens, it matches, because eg, "# 5.0b7 - linux" =~ "5.0" is true:
  if ($origFile[0] =~ $oldVersion)

The simple fix for this is getting pickier about what we match here. Better fix would be checking the actual data line's version/buildid, might not be worth the trouble though.

Comment 1

[Justin Wood (:Callek)]

Attachment: v1

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 596489 [details] [diff] [review]
v1

Review of attachment 596489 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, I think this works...

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 596489 [details] [diff] [review]
v1

http://hg.mozilla.org/build/tools/rev/5be9351f1e0b