669727 - nsNodeUtils.cpp:518:10: warning: variable ‘isDeepDocumentClone’ set but not used [-Wunused-but-set-variable]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

bug 564863 removed* the last usage of PRBool isDeepDocumentClone, triggering:
{
content/base/src/nsNodeUtils.cpp:518:10: warning: variable ‘isDeepDocumentClone’ set but not used [-Wunused-but-set-variable]
}

* http://hg.mozilla.org/mozilla-central/rev/ce0bc496b725#l13.12

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix (remove unused variable)

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 544323 [details] [diff] [review]
fix (remove unused variable)

This is peterv's code. Patch obviously maintains current behavior, but I'm not sure if there's a bug here that should be fixed instead.

Comment 3

[Daniel Holbert [:dholbert]]

CC'ing smaug in case he has thoughts on comment 2, as he added the "isDeepDocumentClone" variable in the first place.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Bug 514487 added a test, so things should be working ok.

Comment 5

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a70a94b0eb87

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/a70a94b0eb87