6698 - Display of non-Latin 1 body is completely broken

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P1)

Description

[Katsuhiko Momoi]

** Observed with 5/18/99 Win32 build **
** The display was not broken with 5/17/99 Win 32 build **

I have messages sent from Messenger 4.6/4.51 and OE5/4 in about
11 languages. The thread pane headers and the view pane
headers display correctly but the body of these messages except
Latin 1 is not displaying correctly. It does not seem to be
using a correct font.

The display was working OK with yesterday's build.
The problem began with today's build.
This is a near complete regression from M6 and prevents us
from doing any credible international testing. And of course,
we can't ship M6 like this, either.

Comment 1

[Katsuhiko Momoi]

ftang made a temporary code change disabling Meta tag recognition
for 1 day. This, according to ftang, is why Mail display is
failing (because the mail code relies on a meta tag as it generates
UTF-8 page.)
This would also affect browser display for pages with Meta tags.
Encoding menu is working, however.

Please mark it resolved when the new code is in.

Comment 2

[Katsuhiko Momoi]

Changed the Product to Browser.

Comment 3

[Katsuhiko Momoi]

When this is fixed, we'll check on the mail side, teruko & blee,
please check on the browser side.

Comment 4

[Frank Tang]

Set this to P1 M6

Comment 5

[Frank Tang]

Fixed and check in

Comment 6

[Katsuhiko Momoi]

I'm re-opening this bug since ftang's fix has been backed out in
Bug 6780. Until Bug 6780 is fixed, we won't see non-ASCII body properly
unless the encoding is manually set to UTF-8.
I've switched back the Product to MailNews since that's where we
feel the primary effect though the problem should also be visible in
Browser.

Comment 7

[Frank Tang]

will check in tonight to both branch and tip

Comment 8

[Frank Tang]

will check in to branch and tip tonight.

Comment 9

[Frank Tang]

The following file have been check in
files in tip:
mozilla/intl/chardet/src/nsMetaCharsetObserver.cpp 1.8
mozilla/layout/html/document/src/nsHTMLDocument.cpp 3.117
mozilla/htmlparser/src/nsParser.cpp 3.95

files in branch:
mozilla/intl/chardet/src/nsMetaCharsetObserver.cpp 1.7.4.1
mozilla/layout/html/document/src/nsHTMLDocument.cpp 3.116.4.1
mozilla/htmlparser/src/nsParser.cpp 3.94.4.1

Comment 10

[Katsuhiko Momoi]

Frank, I looked at the tip build for today (5/25/99 M7 build)
and Mail body display is still broken. Naoki, the menu is working
if I switch the value to UTF-8 and try Japanese. I thought you said
that the menu will not be working as part of Frank's fix.

Comment 11

[Katsuhiko Momoi]

I don't think there is a branch build (M6) yet today. The last one
was from yesterday evening around 5pm.

Comment 12

[Frank Tang]

reassign this to nhotta. There are some problem between the messanger and gecko.
Naoki, please take a look at decide weather this is a M6 stoper.

Comment 13

[nhottanscp]

According to Frank, the change was not included to Win32 build.
Let's wait for the next build and verify again.

Comment 14

[Katsuhiko Momoi]

There is display failure for both Message pane header and body for
non-UTF-8 non-ASCII message headers and body. This has been attributed to
Bug 6890.

We have another type of failure reported by Marina today for
the 5/26/ M7 build. That is the failure of body for Japanese
messages. I saw it happen a few times today (but not very often)
where the thread pane and message pane headers displayed OK but
not the body. I don't know if this due to Bug 6890 or this bug.

For me, this fix is working most of the time, and I'm inclined to
mark it verified resolved. We can re-open it or file a new bug
if further investigation reveals a new problem related to this one.

Mrking it verified fixed for now.

Comment 15

[Katsuhiko Momoi]

The verification was done on 5/25/99 Win32 M6 build.