670079 - stop caching plugin instances

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Josh Aas]

I don't think we ever want to restart a plugin instance so we can stop caching them entirely and remove code that looks for an old stopped instance to re-use when instantiating.

I'm not sure we want to support NPPVpluginKeepLibraryInMemory either. Right now that marks an instance for caching, which effectively prevents its plugin from ever unloading since an instance will remain indefinitely. This is a silly way to implement it, a better way would be to just mark the plugin as do-not-unload when this is set on any instance. However, since we don't unload plugins by default anyway this isn't really an issue.

Comment 1

[Josh Aas]

Attachment: fix v1.0

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 544733 [details] [diff] [review]
fix v1.0

Yeah, this never seemed like a good idea to me either. r=jst

Comment 3

[Josh Aas]

pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/b4725ef65601

Comment 4

[Nochum Sossonko [:Natch]]

Does this fix bu 659348?

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

If I'm reading 
  https://wiki.mozilla.org/RapidRelease#Merge_and_Release_Dates
correctly this fix was first in Firefox 8.

Comment 6

[Steven Michaud [:smichaud] (Retired)]

Yes.  And this is confirmed by the names of the 2011-07-08 and 2011-07-09 mozilla-central nightlies, which claim to be "8.0a1".