670111 - Add double overloads to NSToCoord(Round|Floor|Ceil|Clamped) to stop numerous build warnings

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ed Morley [:emorley]]

Bug 447838 is trying to stop the build warnings in nsTextFrameThebes.cpp, many of which are along the lines of:
> warning C4244: 'argument' : conversion from 'gfxFloat' to 'float', possible loss of data

To save countless delightful changes like:
-    *snappedEndEdge = NSToCoordFloor(gfxFloat(frameWidth) - advanceWidth);
+    *snappedEndEdge = NSToCoordFloor(float(gfxFloat(frameWidth) - advanceWidth));

Roc suggested that I add double overloads to NSToCoord(Round|Floor|Ceil|Clamped).

A quick glance at |conversion from 'gfxFloat' to 'float'| build warnings in files other than nsTextFrameThebes.cpp, shows that this will fix some of the warnings in other files as well :-)

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Double overloads of NSToCoord(Round|Floor|Ceil|Clamped), broken out from bug 447838.

Thanks :-)

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 544777 [details] [diff] [review]
Patch v1

Review of attachment 544777 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 3

[Ed Morley [:emorley]]

Passed try:
http://dev.philringnalda.com/tbpl/?tree=Try&rev=7e2dec83b318

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e2139ab44181

Comment 5

[Mounir Lamouri (:mounir)]

Merged:
http://hg.mozilla.org/mozilla-central/rev/e2139ab44181

Comment 6

[(no longer active)]

I've backed this out from inbound to see if it affects the frequency of bug 629196: <http://hg.mozilla.org/integration/mozilla-inbound/rev/2f5959074445>

Comment 7

[Joe Drew (not getting mail)]

And this backout was merged to m-c: http://hg.mozilla.org/mozilla-central/rev/2f5959074445

Comment 8

[Ed Morley [:emorley]]

Ehsan, please can this and bug 670338 be relanded now, given 4 x 100 OS X 10.6 reftest try runs showed no correlation (https://bugzilla.mozilla.org/show_bug.cgi?id=629196#c27) and that the test has now been adjusted / bug 629196 resolved fixed anyway (https://bugzilla.mozilla.org/show_bug.cgi?id=629196#c30).

Thanks :-)

Comment 9

[(no longer active)]

Sure, just pushed them both to inbound.  Thanks for the investigation!

Comment 10

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/10601c08fc30