670172 - Splinter should add "Review" links in request.cgi lists

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Splinter, defect)

Description

[(not currently active) Ted Mielczarek]

I generally use my "Request Queue" via request.cgi to work through my pending reviews. Since I do them all in Splinter nowadays, it would be nice if Splinter added a "Review this patch" link to each entry in the list.

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to add review link to requests list (v1)

This patch adds a new 'after_attachment' hook to request/queue.html.tmpl to allow Splinter to add a [review] link after a patch's description. I would also need to push the new hook upstream as well. Some changes were needed to request.cgi to add the ispatch attribute to the requests list. 

dkl

Comment 2

[:glob ✱]

Comment on attachment 544903 [details] [diff] [review]
Patch to add review link to requests list (v1)

Review of attachment 544903 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob, fix nits on check-in.

this hook really should exist upstream; care you able to file a bug for that?

::: request.cgi
@@ +111,4 @@
>                  flags.status,
>                  flags.bug_id, bugs.short_desc,
>                  products.name, components.name,
> +                flags.attach_id, attachments.description, 

nit: don't need to add a trailing space here

@@ +301,5 @@
>          };
>          push(@requests, $request);
>      }
>  
> +    use Data::Dumper; print STDERR Dumper \@requests;

oops

Comment 3

[David Lawrence [:dkl]]

Thanks glob. Nits fixed on checkin. Will file bug for hook.

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified request.cgi
added extensions/Splinter/template/en/default/hook/request
added extensions/Splinter/template/en/default/hook/request/queue-after_attachment.html.tmpl
modified template/en/default/request/queue.html.tmpl
Committed revision 7791

dkl

Comment 4

[(not currently active) Ted Mielczarek]

Did this get reverted somehow? I'm not seeing these links anymore in my request queue.

Comment 5

[David Lawrence [:dkl]]

(In reply to comment #4)
> Did this get reverted somehow? I'm not seeing these links anymore in my
> request queue.

Sigh. The upstream accepted the new template hook but the naming was different and I failed to change it in our customization. I have committed the change now and it should be in the next code push to production.

dkl