670230 - [OS/2] missing includes in nsPluginInstanceOwner

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Walter Meinl]

Creation of nsPluginInstanceOwner missed a few includes/defines for OS/2 - breaking the build

Comment 1

[Steven Michaud [:smichaud] (Retired)]

Please attach (don't paste in) the build error(s).

When (with which patch on on what date) did the problem start happening?

And what, exactly, is the status of our OS/2 builds?  Is someone doing regular builds?

Comment 2

[Walter Meinl]

Attachment: patch

Comment 3

[Walter Meinl]

(In reply to comment #1)
> Please attach (don't paste in) the build error(s).
unfortunately I don't have the log anymore. The error was about HPS not declared in this scope
> 
> When (with which patch on on what date) did the problem start happening?
I've added bug660721 (when nsPluginInstanceOwner.cpp was ripped out from code living in other files)
> 
> And what, exactly, is the status of our OS/2 builds?  Is someone doing
> regular builds?
We have currently a shortcoming in official builds until IPC is finally ported. However, to keep our code outside of IPC up-to-date, I'm building (more or less) every day privatly, currently posting from 8.0a1 BuildID=20110707221328
When we're finished with the IPC port we want to come back with official builds.

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/6c5f3085166c