670251 - Backout disabledtext check since it is causing user autocomplete to be very slow

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[David Lawrence [:dkl]]

As discussed in bug 658929, searching for users for the autocomplete feature of Bugzilla is slower when checking for disabledtext = ''. This bug is about backing out the check on BMO until we are able to upgrade to 4.2. With 4.2 this has been reworked to use a boolean (is_enabled) instead and performs much better. We decided that backporting the upstream fix would not be ideal as it requires a database schema change and associated downtime.

Patch coming.

dkl

Comment 1

[David Lawrence [:dkl]]

To clarify, Bugzilla::User::match will still support excluding of disabled users. This patch will update the JS code in js/field.js to pass include_disabled = 1 to override the default behavior.

dkl

Comment 2

[David Lawrence [:dkl]]

Attachment: Patch to include disabled users in autocomplete (v1)

Updates JS code for user autocomplete to include disabled users by default.

Comment 3

[:glob ✱]

Comment on attachment 544908 [details] [diff] [review]
Patch to include disabled users in autocomplete (v1)

r=glob

nice :)

Comment 4

[David Lawrence [:dkl]]

Should be in the next code update normally on thursdays.

Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified js/field.js
Committed revision 7790.

dkl