670284 - Show compatibility error for using nsIJSON in Firefox 7

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P2)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 645922, the main methods in nsIJSON have been removed for Firefox 7, and now the global JSON object should be used instead. Pretty much every use of nsIJSON in an add-on has been eliminated, so we should check for any instance of nsIJSON.

This should show an error and prevent the add-on from being upgraded.

Message:

The encode and decode methods in nsIJSON have been removed in Firefox 7. You can use the methods in the global JSON object instead. See <LINKED_MDC_ARTICLE> for more information.

Link: https://developer.mozilla.org/En/Using_native_JSON

Affected add-on:

https://addons.mozilla.org/en-US/firefox/addon/wolfram-alpha-google/

Comment 1

[Matt Basta [:basta]]

Merged:

https://github.com/mozilla/amo-validator/commit/572010cfde71f5728c1adebc4aec0c26387193dc

Comment 2

[krupa raj[:krupa]]

https://addons.allizom.org/en-US/firefox/addon/wolfram-alpha-google is not one of the add-ons that failed validation.

reopening so that basta can investigate

Comment 3

[Matt Basta [:basta]]

The WolframAlpha Google extension uses a technique that we can't currently detect with the validator. They're aliasing Components.interfaces and Components.classes to members of non-existant objects (for reasons that are difficult to explain concisely). I'm working now to make the validator accept those aliases and make the non-existant objects existant when the members are set.

TL;DR The issue with the WA Google widget is somewhat unrelated to this bug; feel free to keep it open or close it as necessary.

Comment 4

[krupa raj[:krupa]]

The 'Deprecated nsIJSON methods in use.' error is shown for  https://addons.allizom.org/en-US/developers/addon/google-date-keeper/validation-result/44981

I have also checked a bunch of other add-ons which use this method(Browse periodically,Feed Sidebar, Download Master Toolbar)

Basta, please file a separate bug to track comment 3. If you close this bug, I'll verify it.

Comment 5

[krupa raj[:krupa]]

using nSIJSON shows a warning instead of an error now. Marking this verified at https://addons.allizom.org/en-US/developers/addon/download-master-toolbar/validation-result/63116

Issue from comment 3 is being tracked at bug 673536