Closed
Bug 670986
Opened 13 years ago
Closed 13 years ago
Create nsLocation.h to declare nsLocation instead of doing that in nsGlobalWindow.h
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: mounir, Assigned: mounir)
Details
(Whiteboard: [inbound])
Attachments
(1 file, 3 obsolete files)
|
9.49 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Attachment #545415 -
Flags: review?(jst)
|
||
Comment 1•13 years ago
|
||
Um, did you forget to hg add nsLocation.h? :)
|
Assignee | |
Comment 2•13 years ago
|
||
Oups :)
Attachment #545415 -
Attachment is obsolete: true
Attachment #545634 -
Flags: review?(jst)
Attachment #545415 -
Flags: review?(jst)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Without SizeOf() declaration, it might be even better...
Attachment #545634 -
Attachment is obsolete: true
Attachment #545637 -
Flags: review?(jst)
Attachment #545634 -
Flags: review?(jst)
|
||
Comment 4•13 years ago
|
||
I've wanted to do that for quite a while... Thanks!
|
|
||
Updated•13 years ago
|
Attachment #545637 -
Flags: review?(jst) → review+
|
|
Assignee | |
Updated•13 years ago
|
Flags: in-testsuite-
Whiteboard: [needs review] → [inbound]
|
||
Comment 5•13 years ago
|
||
this has been backed out by ehsan due to bustage with all the other changesets in the same push
Whiteboard: [inbound]
|
|
Assignee | |
Comment 6•13 years ago
|
||
Trying to figure out why this is failing to build on Windows...
Attachment #545637 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [inbound]
|
|
||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/b53395484bdf
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•