671259 - Disable use of GL when TFP is not available

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Rob Bradford]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/534.30 (KHTML, like Gecko) Chrome/12.0.742.112 Safari/534.30

Steps to reproduce:

When TFP (texture from pixmap / GLX_EXT_texture_from_pixmap) is unavailable we should not try and provide a GL context.



Expected results:

We should fail initialisation as if GL was not available.

Matt made the following comment on #670645

"I think we should just return PR_FALSE here, performance without this enabled
is significantly reduced over just using X to composite."

Comment 1

[Rob Bradford]

Just returning PR_FALSE as discussed here has the side effect of disabling WebGL...

Comment 2

[Matt Woodrow (:mattwoodrow)]

Good catch.

Probably the better thing to do is modify the GfxInfoX11/glxtest code to test for the presence of texture_from_pixmap and block the accelerated layers feature.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Block OpenGL when texture_from_pixmap isn't found

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 549252 [details] [diff] [review]
Block OpenGL when texture_from_pixmap isn't found

r+ with the following comment:

>+    // Disable OpenGL layers when we don't have texture_from_pixmap because it regresses performance. 
>+    if (aFeature == nsIGfxInfo::FEATURE_OPENGL_LAYERS && !mHasTextureFromPixmap) {
>+        *aStatus = nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION;
>+        aSuggestedDriverVersion.AssignLiteral("Anything with EXT_texture_from_pixmap support");
>+        return NS_OK;
>+    }
>+

This is getting injected in about:support in a localized string that says "Try upgrading your driver to version %s or newer" or some such.

So this is going to get very confusing. At least add some kind of brackets to make the sentence easy to parse:

"<Anything with EXT_texture_from_pixmap support>"

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Block OpenGL when texture_from_pixmap isn't found v2

Fixed review comment, carrying forward r=bjacob

Comment 6

[Matt Woodrow (:mattwoodrow)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/83fe19966844

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/83fe19966844