671274 - created 2 addons with builder. both add an item to context-menu. clicking either one does same action though.

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[noitidart]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:5.0) Gecko/20100101 Firefox/5.0
Build ID: 20110615151330

Steps to reproduce:

created 2 addons with builder. first addon i finished then downloaded then installed. 2nd addon is in testing using the usual builder test button. both addons add an item to context-menu.
1st addon is here: https://builder.addons.mozilla.org/addon/1009452/latest/
2nd addon is here: https://builder.addons.mozilla.org/addon/1009591/latest/


Actual results:

clicking on either item launches the postMessage of the 2nd addon. there was a link in the tab i was in that opened a new window, i right clicked and tested, and now both menu items are launching the postMessage of the 1st addon.


Expected results:

menu item added by installed addon should launch its own postMessage. menu item added by the addon in testing should launch its own postMessage.

Comment 1

[noitidart]

downloaded and installed both addons. same problem.

Comment 2

[Drew Willcoxon :adw]

Attachment: patch

Thank you very much for reporting this.

The problem is that item IDs are not unique to module instances, but the click-handling code assumes they are.

Comment 3

[noitidart]

My pleasure :) So glad I could help. :)

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 545724 [details] [diff] [review]
patch

r=myk

Comment 5

[Drew Willcoxon :adw]

The patch for bug 669475 included the fix to this bug, so marking this bug as fixed.

Thanks again, noitidart.  If you notice any more problems, please don't hesitate to file more bugs.

Comment 6

[noitidart]

My pleasure I cant wait to see builder out nice and perfect :)