671553 - Remove the navigation toolbar's custom button appearance in small icons mode; invert icons on dark personas and glass

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch v2

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch v3

another untested patch!

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch v3

typo eliminated

Comment 4

[Dão Gottwald [:dao]]

I'm back home and was finally able to test this. The latest patch appears to be working as expected.

Comment 5

[Stephen Horlander [:shorlander]]

Comment on attachment 546274 [details] [diff] [review]
patch v3

Review of attachment 546274 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Currently missing inverted icons for New Tab, Panorama and dropdown markers. Should we handle those in followup bugs?

Comment 6

[Stephen Horlander [:shorlander]]

Attachment: Screenshot

Comment 7

[Dão Gottwald [:dao]]

(In reply to comment #5)
> Currently missing inverted icons for New Tab, Panorama and
> dropdown markers. Should we handle those in followup bugs?

Yes. Bug 580194, I guess.

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/ed75122f827c
http://hg.mozilla.org/mozilla-central/rev/6ffb760a41ca

Comment 9

[Siddhartha Dugar [:sdrocking]]

Nice work! But I found an issue.
Put the sync button next to the tabs. Now do a sync.
The sync button changes to a back button. Please fix this.

Comment 10

[Siddhartha Dugar [:sdrocking]]

Note: this happens only with the default theme.

Comment 11

[Dão Gottwald [:dao]]

Please file a new bug.

Comment 12

[Siddhartha Dugar [:sdrocking]]

(In reply to comment #11)
> Please file a new bug.

Done, bug 673164

Comment 13

[Bruce A. Wittmeier]

Thanks, Dão.  Looks good - much cleaner.

Comment 14

[bogas04]

Attachment: Must be implemented on Tab Scroll Buttons too

Comment 15

[Siddhartha Dugar [:sdrocking]]

(In reply to bogas04 from comment #14)
> Created attachment 552949 [details]
> Must be implemented on Tab Scroll Buttons too

The remaining work is being tracked in Bug 580194

Comment 17

[BoffinBrain]

The new inverted icons are a good idea, but the removal of the button styles for the navigation toolbar was a very bad one.  This has caused grief for many users and skin writers.  See why at http://forums.mozillazine.org/viewtopic.php?f=38&t=2357753

This bug actually does two completely separate things and should have been split in two.

We now have a bug tracker to revert the navigation bar change introduced here: bug #700972