67203 - browser not opening secure site

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P1)

Description

[Tracy Walker [:tracy]]

seen on commercial builds:

windows 2001-01-31-06-mtrunk
linux 2001-01-31-06-mtrunk

-attempt to go to the secure site above.

the browser does nothing.

Comment 1

[John Unruh]

Reassigning

Comment 2

[Daniel (Leaf) Nunes]

psm starts up fine... and IMAP/S works, so this is a browser problem. gagan?

Comment 3

[Javier Delgadillo]

I just re-built on Mac and whenever I type https://, the following line asserts
http://lxr.mozilla.org/mozilla/source/netwerk/protocol/http/src/nsHTTPHandler.cpp#273

This looks like a necko problem.

Comment 4

[Javier Delgadillo]

adding self to cc list.

Comment 5

[Javier Delgadillo]

Attachment: After quick code check, found a fix.

Comment 6

[Matthias Versen [:Matti]]

*** Bug 67249 has been marked as a duplicate of this bug. ***

Comment 7

[Brian Ryner (not reading)]

I've got a slightly better fix, I think.  It lets us not put any HTTPS stuff in
nsHTTPHandler.  Patch coming up.

Comment 8

[Brian Ryner (not reading)]

Attachment: patch #2

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

r=dbaron, although perhaps this is a case where it would be better to skip the
optimization (maybe ask gagan once this is less urgent)?

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 11

[Brian Ryner (not reading)]

Checked in fix.  gagan, feel free to comment regarding what the "right fix" here is.

Comment 12

[Gagan]

I completely agree with bryner here. we should keep HTTPS stuff out of HTTP as 
much as possible and his fix is the right one. 

Comment 13

[John Unruh]

Verified on the 2/1 Win, Mac and Linux builds.

Comment 14

[John Unruh]

Mass changing Security:Crypto to PSM

Comment 15

[John Unruh]

Mass changing Security:Crypto to PSM