Closed
Bug 672110
Opened 13 years ago
Closed 13 years ago
PGO scripts and input are still generated when building with --disable-optimize
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: emorley, Unassigned)
References
Details
Attachments
(1 file)
|
733 bytes,
patch
|
ted
:
review-
|
Details | Diff | Splinter Review |
PGO scripts & input files are unnecessarily generated in the objdir (<objdir>/_profile/) when building with --disable-optimize http://mxr.mozilla.org/mozilla-central/source/build/pgo/Makefile.in#54 http://mxr.mozilla.org/mozilla-central/source/build/Makefile.in#56
Flags: in-testsuite-
|
Reporter | |
Comment 1•13 years ago
|
||
Two line changes, adds an |ifdef MOZ_OPTIMIZE| to the pgo dir line in /build/Makefile.in Passed try: http://dev.philringnalda.com/tbpl/?tree=Try&rev=556cec8038c2
Attachment #546408 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 546408 [details] [diff] [review] Patch v1 Review of attachment 546408 [details] [diff] [review]: ----------------------------------------------------------------- I don't think we want this. We already use this script for the Valgrind builds (which are --enable-optimize, so it wouldn't actually break them), but there's no guarantee that we won't want to use it for something else in the future.
Attachment #546408 -
Flags: review?(ted.mielczarek) → review-
|
|
Reporter | |
Comment 3•13 years ago
|
||
Ok, no worries.
Assignee: bmo → nobody
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•