672583 - MacLaunchHandler.cc incorrectly uses NS_ARRAY_LENGTH on a pointer

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: Mac, defect)

Description

[Josh Matthews [:jdm]]

>87   cpu_type_t *wanted_type = pref_cpu_types;
>88 
>89   if (aRestartType & nsIAppStartup::eRestarti386)
>90     wanted_type = cpu_i386_types;
>91   else if (aRestartType & nsIAppStartup::eRestartx86_64)
>92     wanted_type = cpu_x64_86_types;
>93 
>94   // Set spawn attributes.
>95   size_t attr_count = NS_ARRAY_LENGTH(wanted_type);

Comment 1

[Josh Matthews [:jdm]]

Attachment: Avoid calling NS_ARRAY_LENGTH on a pointer.

Comment 2

[Josh Matthews [:jdm]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ca526e2c233a

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We should use a template to ensure that NS_ARRAY_LENGTH is only used on an array.

Comment 4

[Josh Matthews [:jdm]]

Coincidentally, I have a patch that does that, which is what found this instance.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Nice.

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/ca526e2c233a