672745 - Add "Changes not ready for localization" Section in Contributor Dashboard

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Scoobidiver (away)]

Add a "Changes not ready for localization" section in the Contributor dashboard containing articles where the last approved revision is not ready for localization.

Comment 1

[Kadir Topal [:atopal]]

I wonder if the localization dashboard is the right place for that. It would be rather confusing to have something on that dashboard that you can't do anything about, no? Maybe the KB dashboard would be a better place.

Comment 2

[Scoobidiver (away)]

(In reply to comment #1)
> I wonder if the localization dashboard is the right place for that.
Where do you see a reference to localization dashboards in my comment?

> Maybe the KB dashboard would be a better place.
I don't know this KB dashboard.
According to me, the Contributor dashboard is the best place: https://support.mozilla.com/en-US/contributors

Comment 3

[Kadir Topal [:atopal]]

Ah, a misunderstanding then. The URL is a bit misleading, if you look into the sidebar, it says KB dashboard. Anyway, I think it makes sense to put it on https://support.mozilla.com/en-US/contributors

Comment 4

[Erik Rose [:erik][:erikrose]]

I'm thinking that typo-level changes shouldn't cause a document to show up on this dashboard, since they don't make retranslation necessary. Right?

Comment 5

[Scoobidiver (away)]

(In reply to Erik Rose [:erik] from comment #4)
> I'm thinking that typo-level changes shouldn't cause a document to show up
> on this dashboard, since they don't make retranslation necessary. Right?
Yes if all the approved revisions not ready for l10n after the last approved ready-for-l10n revision are minor (same as in bug 674835).

Comment 6

[Erik Rose [:erik][:erikrose]]

Fixed in http://github.com/jsocol/kitsune/commit/2b3803282fea629aeeb4458e8dae7fed1d54a4da.

Comment 7

[Rebecca Billings [:rbillings]]

Verified section for 'Changes not ready for localization' displays on /contributors- includes articles not ready for localization

Comment 8

[Scoobidiver (away)]

I can't see the section. Can you set the preference to true for all users in the two staging servers?

Comment 9

[Kadir Topal [:atopal]]

Hey, anyone know what the permission for this is? Actually it should not be behind a permission. At least I see no reason to hide it from anyone.

Comment 10

[Erik Rose [:erik][:erikrose]]

The permission is the same one that lets you mark a revision as ready for l10n. My reasoning was that it's a tease to show people a problem they can't do anything about. Would you like me to not hide it after all?

Comment 11

[Kadir Topal [:atopal]]

Yes, please still show the table. It's good for localizers to see what might be coming up soon. Those would be approved articles that are not ready for l10n yet.

Comment 12

[James Socol [:jsocol, :james]]

Let's spin off a follow up bug for that.

Comment 13

[Kadir Topal [:atopal]]

Done: bug 682311