672939 - fennec package name repeats itself with NDKr5 and greater

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

with NDKr4 our package name is "fennec-8.0a1.en-US.eabi-arm.apk", currently that changes to "fennec-8.0a1.en-US.arm-linuxandroid-arm-linuxandroid.apk" with NDKr5 and newer. This patch fixes that to be "fennec-8.0a1.en-US.android-arm.apk"

The core problem is the vendor and os weren't separated by a - in config.sub so we couldn't extract its components properly. So in autoconfig.mk we had something like this:
TARGET_CPU      = arm-linuxandroid
TARGET_VENDOR   = arm-linuxandroid
TARGET_OS       = arm-linuxandroid

with this patch, that turns into:
TARGET_CPU      = arm
TARGET_VENDOR   = linux
TARGET_OS       = android


which seems more sane to me.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 547229 [details] [diff] [review]
patch

Sounds good to me, but you should add this to js/src/ctypes/libffi.patch so that we don't accidentally blow away that bit in the future.

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/cdec5871f47b