Closed
Bug 672980
Opened 13 years ago
Closed 13 years ago
Macro name in AC_DEFUN should be quoted
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla8
People
(Reporter: hiro, Assigned: hiro)
Details
Attachments
(2 files)
6.40 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
10.33 KB,
patch
|
Callek
:
feedback+
|
Details | Diff | Splinter Review |
Macro name in AC_DEFUN should be quoted.
Comment 1•13 years ago
|
||
Comment on attachment 547280 [details] [diff] [review] A patch Why is this important? Unless you're worried about multiple inclusion of these files in a way that would cause us to expand it the second time...
Assignee | ||
Comment 2•13 years ago
|
||
Actually it is not so important now but I suppose it might have to be changed in the future. Please see http://sources.redhat.com/automake/automake.html#Extending-aclocal
Assignee | ||
Updated•13 years ago
|
Attachment #547280 -
Flags: review?(ted.mielczarek)
Updated•13 years ago
|
Attachment #547280 -
Flags: review?(ted.mielczarek) → review+
Updated•13 years ago
|
Assignee: nobody → hiikezoe
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 3•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/0adaae140642
Keywords: checkin-needed
Whiteboard: [inbound]
Comment 4•13 years ago
|
||
Backed-out from inbound due to a perma-orange, see: http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0adaae140642 The patch in this bug might not bee related, the entire push has been backed out.
Whiteboard: [inbound]
Comment 5•13 years ago
|
||
(In reply to Mounir Lamouri (:volkmar) from comment #4) > Backed-out from inbound due to a perma-orange, see: > http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0adaae140642 > > The patch in this bug might not bee related, the entire push has been backed > out. maybe, this perma-orange is caused by difference between /js/src/build/autoconf/*.m4 and /build/autoconf/*.m4 . /js/src/build/autoconf/*.m4 should be identical /build/autoconf/*.m4 .
Comment 6•13 years ago
|
||
(In reply to ABE Hiroki (hATrayflood) from comment #5) > (In reply to Mounir Lamouri (:volkmar) from comment #4) > > Backed-out from inbound due to a perma-orange, see: > > http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0adaae140642 > > > > The patch in this bug might not bee related, the entire push has been backed > > out. > > maybe, this perma-orange is caused by difference between > /js/src/build/autoconf/*.m4 and /build/autoconf/*.m4 . > /js/src/build/autoconf/*.m4 should be identical /build/autoconf/*.m4 . That is exactly it, if you can upload a new patch (carry forward the r+) just copying the build/autoconf/*.m4 to the js/src/build/autoconf... I can reland within the next 24 hours for you.
Comment 7•13 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #6) > (In reply to ABE Hiroki (hATrayflood) from comment #5) > > (In reply to Mounir Lamouri (:volkmar) from comment #4) > > > Backed-out from inbound due to a perma-orange, see: > > > http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0adaae140642 > > > > > > The patch in this bug might not bee related, the entire push has been backed > > > out. > > > > maybe, this perma-orange is caused by difference between > > /js/src/build/autoconf/*.m4 and /build/autoconf/*.m4 . > > /js/src/build/autoconf/*.m4 should be identical /build/autoconf/*.m4 . > > That is exactly it, if you can upload a new patch (carry forward the r+) > just copying the build/autoconf/*.m4 to the js/src/build/autoconf... I can > reland within the next 24 hours for you. sorry, I can't upload a new patch. I'm out now, so I don't have build environment here. Ikezoe-san: Can you followup this patch ?
Comment 8•13 years ago
|
||
patch v2. fix perma-orange http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0adaae140642
Attachment #551887 -
Flags: review?(bugspam.Callek)
Assignee | ||
Comment 9•13 years ago
|
||
(In reply to ABE Hiroki (hATrayflood) from comment #8) > Created attachment 551887 [details] [diff] [review] [diff] [details] [review] > patch v2 > > patch v2. > fix perma-orange > http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0adaae140642 Wow! Thank you so much! I did not know existence of check-sync-dirs.py! I am sorry and thank you!
Updated•13 years ago
|
Attachment #551887 -
Flags: review?(bugspam.Callek) → feedback+
Comment 10•13 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #9) > (In reply to ABE Hiroki (hATrayflood) from comment #8) > > Created attachment 551887 [details] [diff] [review] > > patch v2 > > > > patch v2. > > fix perma-orange > > http://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0adaae140642 > > Wow! Thank you so much! > > I did not know existence of check-sync-dirs.py! I am sorry and thank you! Even those of us who do know of it, forget it a lot. No big deal. Relanded as: http://hg.mozilla.org/integration/mozilla-inbound/rev/f95d2c738d52
Whiteboard: [inbound]
Comment 11•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/f95d2c738d52
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•