673049 - Forwarding an .eml message causes message compose error

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[davepenfold]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0.1) Gecko/20100101 Firefox/5.0.1
Build ID: 20110707182747

Steps to reproduce:

Save a message to .eml format
Open .eml message in TB (opens in new window)
Click on Forward



Actual results:

First attempt, compose window opens with blank subject line
On second attempt, error: An error occurred while creating a message compose window. Please try again.



Expected results:

Compose window should open as normal without error so email can be forwarded

Comment 1

[Ludovic Hirlimann [:Usul]]

Does this happens in -safe-mode (see http://support.mozillamessaging.com/en-US/kb/Safe-Mode) ?

Comment 2

[davepenfold]

Yes same issue in safe mode

Comment 3

[Jim Porter (:squib)]

Confirmed on nightly. I'm in the process of narrowing down where this is happening...

Comment 4

[Jim Porter (:squib)]

Fallout from bug 583587, which adds references to forwarded messages, but this breaks for .emls because we can't get an nsIMsgDBHdr for them.

Comment 5

[Jim Porter (:squib)]

Attachment: Fix this

Here's a quick one-line patch to fix this. No tests, since it's just one line (though I keep thinking when my patch queue isn't full to bursting that I should write some more tests for .emls).

Comment 6

[Jim Porter (:squib)]

Attachment: Fix this (again)

Sorry, *this* is a one-line fix. (The previous patch had an extra blank line that snuck in.)

Comment 7

[Jonathan Protzenko [:protz]]

Comment on attachment 547339 [details] [diff] [review]
Fix this (again)

Looks like the right to do. Thanks for fixing this so quickly.

Comment 8

[Jim Porter (:squib)]

Checked in: http://hg.mozilla.org/comm-central/rev/bfee0c972a27

Comment 9

[Jim Porter (:squib)]

Comment on attachment 547339 [details] [diff] [review]
Fix this (again)

Asking for approval on branches. This is extremely low-risk, and high-gain for anyone who uses .eml files regularly.

Comment 12

[Jim Porter (:squib)]

http://hg.mozilla.org/releases/comm-aurora/rev/5ae46961864a
http://hg.mozilla.org/releases/comm-beta/rev/122457f20209

Comment 13

[Justin Wood (:Callek)]

Odd, this bug looks entirely mailnews core, yet my test on SeaMonkey 2.2 (roughly == to miramar) appears to be fine.