Closed
Bug 673285
Opened 13 years ago
Closed 13 years ago
Investigate speeding up docshell/test/navigation/test_sessionhistory.html
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: jgriffin, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.72 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
As part of the BuildFaster project (see https://wiki.mozilla.org/ReleaseEngineering/BuildFaster), we are investigating whether certain slow mochitests can be sped up. test_sessionhistory.html is a slow test, average execution time on a recent run (in ms): win32-debug, 46186 linux-opt, 28182 macosx64-debug, 51978 win32-opt, 28260 linux64-debug, 44187 linux64-opt, 28247 macosx64-opt, 28796 macosx-debug, 48526 linux-debug, 45130
Reporter | ||
Comment 1•13 years ago
|
||
Olli, as the original test author, would you be willing to help see if this test can be sped up?
Comment 2•13 years ago
|
||
Well, 7s or so is the 1000ms timeouts from nextTest(). I wonder why we need those.... Also some of the subtests have 1000ms timeouts. Past that, this is actually tests for 7 bugs in 1.... I wonder whether any particular subtests are slow here.
Reporter | ||
Comment 3•13 years ago
|
||
This patch removes the 1s timeouts. It passed on try. Do you think it's safe to land?
Attachment #553582 -
Flags: review?(Olli.Pettay)
Updated•13 years ago
|
Attachment #553582 -
Flags: review?(Olli.Pettay) → review+
Reporter | ||
Comment 4•13 years ago
|
||
Landed as http://hg.mozilla.org/integration/mozilla-inbound/rev/cc68eeea347f
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/cc68eeea347f
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Updated•13 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•