Closed
Bug 673417
Opened 13 years ago
Closed 13 years ago
imgLib cleanups
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: jrmuizel, Unassigned)
Details
Attachments
(2 files)
1.22 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
3.16 KB,
patch
|
joe
:
review+
dholbert
:
review-
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•13 years ago
|
||
mLoadTime was added by stuart back in 2001. It hasn't as far as I can tell ever been used.
Attachment #547699 -
Flags: review?(joe)
Reporter | ||
Comment 2•13 years ago
|
||
Attachment #547701 -
Flags: review?(joe)
Comment 3•13 years ago
|
||
Comment on attachment 547701 [details] [diff] [review] Kill more PRBools >diff --git a/modules/libpr0n/src/RasterImage.cpp b/modules/libpr0n/src/RasterImage.cpp >-PRBool >+bool > RasterImage::ShouldAnimate() > { > return Image::ShouldAnimate() && mFrames.Length() >= 2 && > !mAnimationFinished; [...] >diff --git a/modules/libpr0n/src/RasterImage.h b/modules/libpr0n/src/RasterImage.h > protected: >- PRBool ShouldAnimate(); >+ bool ShouldAnimate(); > }; ShouldAnimate overrides an inherited method (from 'Image'). You'll need to also change the method in Image & VectorImage, or this will break method-overriding.
Comment 4•13 years ago
|
||
Comment on attachment 547699 [details] [diff] [review] mLoadTime has never been used Review of attachment 547699 [details] [diff] [review]: ----------------------------------------------------------------- I only wish I could r- this
Attachment #547699 -
Flags: review?(joe) → review+
Comment 5•13 years ago
|
||
Comment on attachment 547701 [details] [diff] [review] Kill more PRBools Review of attachment 547701 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #547701 -
Flags: review?(joe) → review+
Comment 6•13 years ago
|
||
Comment on attachment 547701 [details] [diff] [review] Kill more PRBools Explicitly setting r-, to make sure Comment 3 gets addressed / noticed. :)
Attachment #547701 -
Flags: review-
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d5db87177940 http://hg.mozilla.org/mozilla-central/rev/39d0aea0cbcd
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Target Milestone: --- → mozilla8
mwu has some mass boolification planned, so you probably don't need to do your own boolification patches.
Comment 9•13 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #6) > Explicitly setting r-, to make sure Comment 3 gets addressed / noticed. :) (/me notes that this was indeed addressed in cset d5db87177940. Thanks! )
You need to log in
before you can comment on or make changes to this bug.
Description
•