Closed Bug 673625 Opened 13 years ago Closed 13 years ago

Add more asserts for scripts

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: billm, Unassigned)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file)

Attached patch patchSplinter Review
The findings in bug 670702 comment 8 suggest two possibilities:
- there's a script that has two owners
- a script is released into the wild, but then freed on an error path

This patch tries to detect those conditions by giving each script an owner field. Whenever we set the owner, we check that it didn't already have an owner. And when we trace it or destroy it, we validate the owner.
Attachment #547853 - Flags: review?(dmandelin)
Comment on attachment 547853 [details] [diff] [review]
patch

Review of attachment 547853 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #547853 - Flags: review?(dmandelin) → review+
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/a840cf51978a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Depends on: 674441
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: