673674 - Fennec freezes when viewing a non .txt file from disk

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mike Hommey [:glandium]]

(This may be related to bug 661978)

- Go to about:sync-log
- Tap on one of the .log files
- Fennec freezes

(tested on a nightly)

I think the same problem may happen for different file types read from other file:///... directory listings (which about:sync-log is, now)

Comment 1

[Tony Chung [:tchung]]

I can reproduce this on Nexus S, 2.3.4.  tapping a log file in about:sync-log will freeze phone, and then throw the force quit activity dialog.  

Working on getting a logcat

Comment 2

[Tony Chung [:tchung]]

Attachment: force quit logcat

Comment 3

[Philipp von Weitershausen [:philikon]]

I'm seeing this too, although I remember it used to work when I first landed bug 610832. I wonder if bug 673309 has fixed it (it renamed .log to .txt).

Comment 4

[Richard Newman [:rnewman]]

Confirmed. Fennec nightly lockup clicking log file. Files stored on SD card.

Comment 5

[Richard Newman [:rnewman]]

Sync annoyance indeed resolved by Bug 673309. Fennec bug still remains, so let's leave this open.

Comment 6

[Philipp von Weitershausen [:philikon]]

Thanks for verifying, Tony. Indeed an underlying Fennec issue, presumably with '.log' files. Changing the summary accordingly.

Comment 7

[Philipp von Weitershausen [:philikon]]

Tony, can you confirm that Fennec Aurora is also affected? If so, we should probably land bug 673309 there too to cover for the underlying Fennec issue.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

I t looks like we try to open the *.log files using nsMimeInfo::LaunchWithFile on desktop and android. Desktop works, opening in the a text editor. Android seems to fail, maybe it is not finding an app (intent) that can open log files.

Comment 9

[Philipp von Weitershausen [:philikon]]

(In reply to comment #8)
> I t looks like we try to open the *.log files using
> nsMimeInfo::LaunchWithFile on desktop and android. Desktop works, opening in
> the a text editor.

Except in most cases .log files (much like .txt files) end up being opened by Firefox itself. (Bug 671911 is an exception that we haven't been able to reproduce.)

> Android seems to fail, maybe it is not finding an app
> (intent) that can open log files.

Either that, or it hangs trying to delegate the intent. Failing explicitly with an error message would be better than hanging.

Comment 10

[Tony Chung [:tchung]]

(In reply to comment #7)
> Tony, can you confirm that Fennec Aurora is also affected? If so, we should
> probably land bug 673309 there too to cover for the underlying Fennec issue.

note to self to check this.

Comment 11

[Doug Turner (:dougt)]

couple of problems.  I am glad that we are going to use .txt for the log files, but that doesn't fix the underlying android's problem.  It looks like nsMIMEInfoAndroid needs some love.  we probably should start caching requests to java.  I'll do that work here.

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I was able to open the log file, after long tapping on it, and then saving it to the doc folder.  I was not able to open it from where it resides normally.  

file:///data/data/org.mozilla.fennec/files/mozilla/<profileid>.default/weave/logs/

Comment 13

[Tony Chung [:tchung]]

changing title to non .txt files, as file handler also locks up on other types (.json)

Comment 14

[Tony Chung [:tchung]]

(In reply to comment #10)
> (In reply to comment #7)
> > Tony, can you confirm that Fennec Aurora is also affected? If so, we should
> > probably land bug 673309 there too to cover for the underlying Fennec issue.
> 
> note to self to check this.

and yes, it happens on aurora and nighty also.

Comment 15

[Doug Turner (:dougt)]

tony, yup.  many file extensions lock things up.

Comment 16

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 17

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 548699 [details] [diff] [review]
patch v.1

Review of attachment 548699 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 18

[Doug Turner (:dougt)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/38e2e8f4b0b2

Comment 19

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/38e2e8f4b0b2

Comment 20

[Aaron Train [:aaronmt]]

Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110728 Firefox/8.0a1 Fennec/8.0a1

Comment 21

[Richard Newman [:rnewman]]

Comment on attachment 548699 [details] [diff] [review]
patch v.1

Per LegNeato's comment on Bug 673309, nominating this for Aurora.

Comment 22

[LegNeato]

Comment on attachment 548699 [details] [diff] [review]
patch v.1

Approved for releases/mozilla-aurora

Comment 23

[Richard Newman [:rnewman]]

Pushed to mozilla-aurora:

  http://hg.mozilla.org/releases/mozilla-aurora/rev/4b51e77c121a

/me thinks about which flags to set...

Comment 24

[Aaron Train [:aaronmt]]

Verified Fixed on Aurora

Mozilla/5.0 (Android; Linux armv7l; rv:7.0a2) Gecko/20110803 Firefox/7.0a2 Fennec/7.0a2