673681 - libxul linking error with --enable-system-ffi and static js lib

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[ojab]

Attachment: Add --enable-system-ffi switch for xulrunner/firefox

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0a1) Gecko/20110723 Firefox/8.0a1
Build ID: 20110723130330

Steps to reproduce:

After bug 551138 it's possible to build mozjs against system libffi, but -lffi isn't added on libxul linking stage.

Comment 1

[ojab]

Shortened libxul linking output:

rm -f libxul.so
/usr/bin/python2.7 /sources/mozilla-central/config/pythonpath.py -I../../config … -lXt -lgthread-2.0 -lfreetype -lz -ldl  -lrt
../../dist/lib/libjs_static.a(CTypes.o): In function `Finalize':
/sources/mozilla-central/js/src/ctypes/CTypes.cpp:5314: undefined reference to `ffi_closure_free'
../../dist/lib/libjs_static.a(CTypes.o): In function `CreateInternal':
/sources/mozilla-central/js/src/ctypes/CTypes.cpp:3239: undefined reference to `ffi_type_pointer'
../../dist/lib/libjs_static.a(CTypes.o): In function `js::ctypes::InitTypeClasses(JSContext*, JSObject*)':
/sources/mozilla-central/js/src/ctypes/typedefs.h:104: undefined reference to `ffi_type_uint8'
/sources/mozilla-central/js/src/ctypes/typedefs.h:105: undefined reference to `ffi_type_sint8'
…

Comment 2

[ojab]

And it happens only with static js library.

Comment 3

[ojab]

Attachment: Add --enable-system-ffi switch for xulrunner/firefox

Add -lffi only in static js lib case.

Comment 4

[ojab]

Attachment: Add --enable-system-ffi switch for xulrunner/firefox

MOZ_STATIC_JS isn't defined, actually ._.
Use "ifndef JS_SHARED_LIBRARY" instead.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Properly support --enable-system-ffi with static js

I think this would be better this way

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 548000 [details] [diff] [review]
Properly support --enable-system-ffi with static js

Review of attachment 548000 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 7

[Mike Hommey [:glandium]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/767b0b274561

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/767b0b274561