673789 - minidump_generator.cc uses mach/ppc/thread_status.h unconditionally

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

mach/ppc/thread_status.h has been removed from the 10.7 sdk. We should add an ifdef for it or just drop it if no breakpad user supports ppc anymore.

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: drop support for ppc

Let me know if I should add a configure check instead.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 548028 [details] [diff] [review]
drop support for ppc

I don't think we're going to drop support for PPC upstream, so we'll probably want to #ifdef this. Something like MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_7 ?

Also, if you could generate this against upstream Breakpad SVN that would be helpful for me:
http://code.google.com/p/google-breakpad/source/checkout

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Only use ppc on mac os < 10.7

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: define HAS_PPC_SUPPORT in the right place

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 548355 [details] [diff] [review]
define HAS_PPC_SUPPORT in the right place

Review of attachment 548355 [details] [diff] [review]:
-----------------------------------------------------------------

Okay, this looks good. I'll land it upstream for you.

Comment 6

[(not currently active) Ted Mielczarek]

Landed in Breakpad SVN:
http://code.google.com/p/google-breakpad/source/detail?r=817

Comment 7

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Thanks!
Should we backport or just update breakpad?

Comment 8

[(not currently active) Ted Mielczarek]

We can land your patch in mozilla-central as well, I still have a few more patches to upstream before we can update our Breakpad snapshot.

Comment 9

[(not currently active) Ted Mielczarek]

http://hg.mozilla.org/projects/build-system/rev/3a7ad3683fbf

Comment 10

[Alexander L. Slovesnik]

>+#ifdef HAS_PPC_SUUPORT
>     case CPU_TYPE_POWERPC:
>       return WriteStackPPC(state, stack_location);
>     case CPU_TYPE_POWERPC64:
>       return WriteStackPPC64(state, stack_location);
>+#endif

Looks like there is typo in patch. s/SUUPORT/SUPPORT

Comment 11

[(not currently active) Ted Mielczarek]

Thanks, I pushed a fix for that upstream:
http://code.google.com/p/google-breakpad/source/detail?r=820

Comment 12

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/3a7ad3683fbf