673804 - Utils.trace() fails since Panorama uses ES5 strict mode

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Access to function.caller is denied in strict mode.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/integration/fx-team/rev/978b92a67b6f

Comment 3

[:Gavin Sharp [email: [e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/978b92a67b6f

Comment 4

[:Gavin Sharp [email: [e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/7083160f09ac

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to comment #4)
> http://hg.mozilla.org/mozilla-central/rev/7083160f09ac

Shouldn't have landed with DONTBUILD, as it was a code change.

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #5)
> (In reply to comment #4)
> > http://hg.mozilla.org/mozilla-central/rev/7083160f09ac
> 
> Shouldn't have landed with DONTBUILD, as it was a code change.

Yep, generally, you shouldn't do that. Initial blame would be on the subsequent changeset for any unforeseen consequences of your push.

Comment 7

[Dão Gottwald [:dao]]

Also, r=me doesn't make sense, but I guess that's a matter of taste. It's just as good as no review but seems less upfront.

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

(In reply to comment #6)
> > Shouldn't have landed with DONTBUILD, as it was a code change.
> 
> Yep, generally, you shouldn't do that. Initial blame would be on the
> subsequent changeset for any unforeseen consequences of your push.

Ok, sorry, I'll keep that in mind.

(In reply to comment #7)
> Also, r=me doesn't make sense, but I guess that's a matter of taste. It's
> just as good as no review but seems less upfront.

True, this was in fact just copied behavior from someone else who I thought did it right...