673815 - trackpad scrolling fails in Nightly, works in Firefox 5.0

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Jo Hermans]

Today I noticed that the nightly version doesn't do the auto-detect anymore (forcing ui.trackpoint_hack.enabled to 1 helps), while Firefox 5.0 works correctly.

I'm using an old driver, Synaptics version 11.1.21.0, on a UltraNavPS2 device.

I think that the reason is that the call to IsObsoleteSynapticsDriver was removed (which I was relying on) and replaced with a check for the Elan Tech driver.

http://hg.mozilla.org/mozilla-central/diff/1d90c5f569a2/widget/src/windows/nsWindow.cpp

This seems to be a different issue than bug 622410.

Comment 1

[Jo Hermans]

The change came from bug 640587, which is now on its way to Firefox 6.0

Comment 2

[Cameron McCormack (:heycam)]

Yeah, the call to IsObsoleteSynapticsDriver should not have been removed as part of the bug 640587 fix.

Comment 3

[Cameron McCormack (:heycam)]

Jo, can you test this tryserver build that has the IsObsoleteSyntapicsDriver call restored?  Please try it without the ui.trackpoint_hack.enabled pref set.

https://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-21c6e9f2c908/try-win32/firefox-8.0a1.en-US.win32.zip

Comment 4

[Jo Hermans]

Yes, this solves the problem for me.

Comment 5

[Cameron McCormack (:heycam)]

Great.  So I want to wait til I'm back in the office next week and verify I haven't broken the other scrolling hacks before requesting review.

Comment 6

[Sami Lappalainen / ZAS DATA]

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=538189 for similar problems in Thunderbird 5.0 and latest-earlybird 7.0a2 .

Comment 7

[Cameron McCormack (:heycam)]

Attachment: Fix Synaptics touchpad scrolling hack requirement detection

Verified that this doesn't cause the Elantech hack detection to break.

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 549924 [details] [diff] [review]
Fix Synaptics touchpad scrolling hack requirement detection

The regression causes touchpad scrolling not to work for users on Thinkpads (and perhaps other machines with Synaptics-based touchpads) using drivers that aren't up to date.

Comment 9

[Christopher Blizzard (:blizzard)]

Comment on attachment 549924 [details] [diff] [review]
Fix Synaptics touchpad scrolling hack requirement detection

Approved for beta (6) and aurora (7).

Comment 10

[Cameron McCormack (:heycam)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/8837999bdd8c

Comment 11

[Cameron McCormack (:heycam)]

http://hg.mozilla.org/releases/mozilla-beta/rev/2f8c75dcbe0b
http://hg.mozilla.org/releases/mozilla-aurora/rev/ff77eadd9142

Comment 12

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/8837999bdd8c

Comment 13

[Jo Hermans]

verfied as fixed in :
Mozilla/5.0 (Windows NT 5.1; rv:8.0a1) Gecko/20110803 Firefox/8.0a1
Mozilla/5.0 (Windows NT 5.1; rv:7.0a2) Gecko/20110803 Firefox/7.0a2

there's no update for 6.0 beta available yet, so that couldn't be verified

Comment 14

[George Carstoiu]

 Mozilla/5.0 (X11; Linux i686; rv:6.0) Gecko/20100101 Firefox/6.0 - beta 5

Jo, can you also please check on the latest beta and modify the status if everything is in order?

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/6.0b5-candidates/

Comment 15

[Jo Hermans]

Yes, that works.

Mozilla/5.0 (Windows NT 5.1; rv:6.0) Gecko/20100101 Firefox/6.0

The User-Agent doesn't tell me the version of course, but browser.startup.homepage_override.buildID was set to 20110804030150

Comment 16

[Cameron McCormack (:heycam)]

Thanks for verifying, Jo!