Closed
Bug 674012
Opened 13 years ago
Closed 13 years ago
Remove "check for gcc 3.0 ABI"
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla10
People
(Reporter: glandium, Assigned: felix)
References
()
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 1 obsolete file)
18.95 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•13 years ago
|
||
We probably don't even build with a gcc that doesn't have the gcc3 ABI.
Summary: Remove "check for gcc 3.0 ABI → Remove "check for gcc 3.0 ABI"
Reporter | ||
Updated•13 years ago
|
Whiteboard: [good first bug]
Updated•13 years ago
|
Assignee | ||
Comment 2•13 years ago
|
||
Removed all uses and checks for HAVE_GCC3_ABI and assumed it to be true throughout.
Reporter | ||
Comment 3•13 years ago
|
||
Comment on attachment 562969 [details] [diff] [review] Remove Checks for HAVE_GCC3_ABI Review of attachment 562969 [details] [diff] [review]: ----------------------------------------------------------------- ::: xpcom/reflect/xptcall/src/md/unix/Makefile.in @@ -371,3 @@ > ASFILES := xptcinvoke_asm_sparc_linux_GCC3.s xptcstubs_asm_sparc_solaris.s > -else > -ASFILES := xptcinvoke_asm_sparc_linux.s xptcstubs_asm_sparc_solaris.s Please remove the file that are not used anymore. @@ -412,3 @@ > ASFILES := xptcinvoke_asm_sparc_solaris_GCC3.s xptcstubs_asm_sparc_solaris.s > else > -ASFILES := xptcinvoke_asm_sparc_solaris_GCC.s xptcstubs_asm_sparc_solaris.s Likewise.
Attachment #562969 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Removed xptcinvoke_asm_sparc_linux.s and xptcinvoke_asm_sparc_solaris_GCC.s
Attachment #562969 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Whiteboard: [good first bug] → checkin-needed
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: checkin-needed
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/47f550b4ef47 I accidentally pushed this patch to mozilla-central while it was living on inbound. On the next merge, it will be merged. Sorry for the mess!
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 7•13 years ago
|
||
Merged from inbound: https://hg.mozilla.org/mozilla-central/rev/934fd93abd86
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•