674228 - enable tegra unittests and talos on remaining project branches

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mike Taylor [:bear]]

enable for the following:

accessibility
build-system
private-browsing
alder
birch
cedar
holly
larch
maple

Comment 1

[Mike Taylor [:bear]]

Attachment: enable unittests and mochitest1-4

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 548465 [details] [diff] [review]
enable unittests and mochitest1-4

>-BRANCHES['addontester']['remote-ts_tests'] = (0, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>-BRANCHES['addontester']['remote-tdhtml_tests'] = (0, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>-BRANCHES['addontester']['remote-tsvg_tests'] = (0, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>-BRANCHES['addontester']['remote-tsspider_tests'] = (0, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>-BRANCHES['addontester']['remote-tpan_tests'] = (0, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>-BRANCHES['addontester']['remote-tp4m_tests'] = (0, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>-BRANCHES['addontester']['remote-tp4m_nochrome_tests'] = (0, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>-BRANCHES['addontester']['remote-twinopen_tests'] = (0, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>-BRANCHES['addontester']['remote-tzoom_tests'] = (0, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>+BRANCHES['addontester']['remote-ts_tests'] = (1, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>+BRANCHES['addontester']['remote-tdhtml_tests'] = (1, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>+BRANCHES['addontester']['remote-tsvg_tests'] = (1, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>+BRANCHES['addontester']['remote-tsspider_tests'] = (1, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>+BRANCHES['addontester']['remote-tpan_tests'] = (1, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>+BRANCHES['addontester']['remote-tp4m_tests'] = (1, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>+BRANCHES['addontester']['remote-tp4m_nochrome_tests'] = (1, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>+BRANCHES['addontester']['remote-twinopen_tests'] = (1, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)
>+BRANCHES['addontester']['remote-tzoom_tests'] = (1, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)

I think we said to not touch addontester, correct?

>     'build-system': {
>-        'enable_talos': False,
>+        'talos_suites': {
>+            'remote-ts': 1,
>+            'remote-tdhtml': 1,
>+            'remote-tsvg': 1,
>+            'remote-tsspider': 1,
>+            'remote-tpan': 1,
>+            'remote-tp4m': 1,
>+            'remote-tp4m_nochrome': 1,
>+            'remote-twinopen': 1,
>+            'remote-tzoom': 1,
>+        },

Don't turn on talos without asking branch owners.
Remove this.

>     'private-browsing': {
>-        'enable_talos': False,
>         'enabled_products': ['firefox'],
>         'enable_nightly': False,
>     },

This too.


>-    'alder': {},
>-    'birch': {},
>-    'cedar': {},
>-    'holly': {},
>-    'larch': {},
>+    'alder': { 'talos_suites': {
>+                                'remote-ts': 1,
>+                                'remote-tdhtml': 1,
>+                                'remote-tsvg': 1,
>+                                'remote-tsspider': 1,
>+                                'remote-tpan': 1,
>+                                'remote-tp4m': 1,
>+                                'remote-tp4m_nochrome': 1,
>+                                'remote-twinopen': 1,
>+                                'remote-tzoom': 1,
>+                               },

Are we enabling the entire talos suite list, or only the limited set?

>     # customizations while booked for bcp47 project as per bug 667734
>     'maple': {
>-        'enable_talos': False,

This too.

Comment 3

[Mike Taylor [:bear]]

Attachment: enable unittests and mochitest1-4

Comment 4

[Mike Taylor [:bear]]

Attachment: enable unittests and mochitest1-4

Comment 5

[Mike Taylor [:bear]]

Attachment: enable unittests and mochitest1-4

Comment 6

[Aki Sasaki (not active)]

Comment on attachment 548476 [details] [diff] [review]
enable unittests and mochitest1-4

Can you update the spreadsheet?

Comment 7

[Mike Taylor [:bear]]

Comment on attachment 548476 [details] [diff] [review]
enable unittests and mochitest1-4

committed changeset 4490:65a0bcdcc3de

Comment 8

[Mike Taylor [:bear]]

Attachment: enable more mochitest-plain unittests

this doesn't have the change for totalChunks, I was having trouble finding which spot to tweak for this

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 548476 [details] [diff] [review]
enable unittests and mochitest1-4

This patch is in production now.

Comment 10

[Mike Taylor [:bear]]

Attachment: enable more mochitest-plain unittests

this is now running on staging

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 549112 [details] [diff] [review]
enable more mochitest-plain unittests

Review of attachment 549112 [details] [diff] [review]:
-----------------------------------------------------------------

Simple change.  I would like to profile these for times in the near future so we can see how much extra time per chunk we have.  My concern is when we add more tests, can we stuff them into the [soon to be] existing 8 chunks, or will we need to add more chunks.

I would think the total runtime/chunks needs to be in the 15 minute (900 seconds) time limit.  We should optimize the chunks that are running so we have room for new tests without adding more chunks just because.

r=me with the one change made below

::: mozilla-tests/config.py
@@ +570,5 @@
> +                                       'modules/libjar/test/mochitest',
> +                                       'layout/inspector/tests',
> +                                       'toolkit/xre/test',
> +                                       'toolkit/components/microformats/tests',
> +                                       'MochiKit-142.2/tests',

MochiKit-1.4.2/tests

Comment 12

[Mike Taylor [:bear]]

Attachment: enable more mochitest-plain unittests

change Harness/sanity to Harness_sanity

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 549381 [details] [diff] [review]
enable more mochitest-plain unittests

Review of attachment 549381 [details] [diff] [review]:
-----------------------------------------------------------------

cool!

Comment 14

[Mike Taylor [:bear]]

Comment on attachment 549381 [details] [diff] [review]
enable more mochitest-plain unittests

ready to queue for reconfig

Comment 15

[Mike Taylor [:bear]]

Comment on attachment 549381 [details] [diff] [review]
enable more mochitest-plain unittests

committed changeset 4510:4930e476fda8

Comment 16

[Mike Taylor [:bear]]

these changes are now all live