Closed
Bug 674246
Opened 13 years ago
Closed 12 years ago
Workaround event handler having the same original prototype node
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(seamonkey2.2 affected, seamonkey2.3 fixed, seamonkey2.4 fixed, seamonkey2.17 fixed)
RESOLVED
FIXED
seamonkey2.17
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(2 files, 1 obsolete file)
1.06 KB,
patch
|
neil
:
review+
Callek
:
approval-comm-aurora+
Callek
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
2.02 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
Over in bug 671192, Neil suggested a possible workaround for the event handler having the same original prototype node by adding a dummy node to each main document. This patch does that, once the core issue is fixed should be able to backout this patch where it lands.
Attachment #548488 -
Flags: review?(neil)
Changes since last version: * Only add dummy node to the one file as that is sufficient.
Attachment #548488 -
Attachment is obsolete: true
Attachment #548488 -
Flags: review?(neil)
Attachment #548557 -
Flags: review?(neil)
Updated•13 years ago
|
Attachment #548557 -
Flags: review?(neil) → review+
Comment on attachment 548557 [details] [diff] [review] Reduced context dummy node fix [Checked in: trunk Comment 2 and comm-aurora/beta Comment 3] http://hg.mozilla.org/comm-central/rev/273d03134e26 Requesting approval to get into comm-aurora/beta to fix this issue.
Attachment #548557 -
Attachment description: Reduced context dummy node fix → Reduced context dummy node fix [Checked in: Comment 2]
Attachment #548557 -
Flags: approval-comm-beta?
Attachment #548557 -
Flags: approval-comm-aurora?
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
status-seamonkey2.2:
--- → affected
status-seamonkey2.3:
--- → affected
status-seamonkey2.4:
--- → affected
status-seamonkey2.5:
--- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.5
Updated•13 years ago
|
Attachment #548557 -
Flags: approval-comm-beta?
Attachment #548557 -
Flags: approval-comm-beta+
Attachment #548557 -
Flags: approval-comm-aurora?
Attachment #548557 -
Flags: approval-comm-aurora+
Comment on attachment 548557 [details] [diff] [review] Reduced context dummy node fix [Checked in: trunk Comment 2 and comm-aurora/beta Comment 3] http://hg.mozilla.org/releases/comm-aurora/rev/12b3fc9c38d0 http://hg.mozilla.org/releases/comm-beta/rev/fc7414166518
Attachment #548557 -
Attachment description: Reduced context dummy node fix [Checked in: Comment 2] → Reduced context dummy node fix [Checked in: trunk Comment 2 and comm-aurora/beta Comment 3]
Target Milestone: seamonkey2.5 → seamonkey2.3
Updated•13 years ago
|
status-seamonkey2.5:
fixed → ---
Target Milestone: seamonkey2.3 → seamonkey2.5
Comment 4•12 years ago
|
||
Bug 773945 fixed this so the patch can be backed out on trunk.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This backs out the workarounds for compose/composer code.
Attachment #696885 -
Flags: review?(neil)
Flags: needinfo?(iann_bugzilla)
Updated•12 years ago
|
Attachment #696885 -
Flags: review?(neil) → review+
Comment on attachment 696885 [details] [diff] [review] Backout workaround [Checked in: Comment 7] http://hg.mozilla.org/comm-central/rev/fb8ce692fcab
Attachment #696885 -
Attachment description: Backout workaround → Backout workaround [Checked in: Comment 7]
Status: REOPENED → RESOLVED
Closed: 13 years ago → 12 years ago
status-seamonkey2.17:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.17
You need to log in
before you can comment on or make changes to this bug.
Description
•