674446 - Add a bit of logging to nsGlueLinkingOSX.cpp

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: add logging

The attached patch helped me debug why my build was not starting on 10.5. I tried to change fprintf to PR_LOG, but got undefined references to _PR_LogPrint.

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 548676 [details] [diff] [review]
add logging

While you're here, I'd suggest to add similar logging to nsGlueLinkingDlopen.cpp and nsGlueLinkingWin.cpp. (And it's expected you can't use PR_LOG: nspr is not available from the xpcom standalone glue).

Note that I'm not an xpcom peer.

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Also add logging to the dlopen case

The Windows file already has error handling, this adding logging to OS X and dlopen.

Comment 3

[(no longer active)]

Let's get this landed when all of the patches have been reviewed.

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Mike, Benjamin r+ the previous patch. The current one adds the extra logging you asked for. Is it OK?

Comment 5

[(no longer active)]

Pushed to inbound.

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/d20e5ec041a4