Closed
Bug 674505
Opened 13 years ago
Closed 13 years ago
IonMonkey: Remove free register check from MoveEmitter
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: adrake, Assigned: adrake)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
1.64 KB,
patch
|
Details | Diff | Splinter Review | |
16.65 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
I applied the attached patch to see if we ever had a free register for cycle resolution. I ran all of my testcases for IonMonkey against both register allocators with that assert there, and not a single one ever had a register available for cycles. Some initial attempts to produce test cases to cause it to be tripped deliberately were unsuccessful. Given this, I propose removing this untested (untestable?) mechanism entirely. Thoughts?
Assignee | ||
Comment 1•13 years ago
|
||
Let's do it. It should remove a lot of code too.
Assignee | ||
Comment 3•13 years ago
|
||
Strips out freeRegs everywhere I could find it, and uses of it all the way up.
Assignee | ||
Updated•13 years ago
|
Attachment #548945 -
Flags: review?(dvander)
Comment on attachment 548945 [details] [diff] [review] Patch v0 Review of attachment 548945 [details] [diff] [review]: ----------------------------------------------------------------- EXTREME R=me
Attachment #548945 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 5•13 years ago
|
||
http://hg.mozilla.org/projects/ionmonkey/rev/b0fafd9fca12
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•