674646 - Do not kill child process when AndroidBridge is not available

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Alex Pakhotin (:alexp)]

Returning false from ContentParent::RecvXXX methods kills the child process. We should return true and handle the error gracefully if it's not really critical.
Methods to be fixed: RecvGetSystemColors, RecvGetIconForExtension.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Is not having the bridge a critical problem?  Sounds like it might be.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #1)
> Is not having the bridge a critical problem?  Sounds like it might be.

It is, but I don't see how killing the child process helps the situation.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

No point in keeping the content process around if we're about to abort.  But you're right, doesn't matter much either way wrt content processes.

Comment 4

[Alex Pakhotin (:alexp)]

(In reply to comment #1)
> Is not having the bridge a critical problem?  Sounds like it might be.

In general it is, but in these two specific cases inability to call those AndroidBridge functions is not really critical. The result would be only cosmetic: some things on the screen might look different, which I believe we can live with if everything else happens to be working.

Comment 5

[Alex Pakhotin (:alexp)]

Attachment: Fix

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/33b34c07f8fc