674731 - WebGL/ANGLE interop with D3D layers requests incorrect extension

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

GLContextEGL requires extension "EGL_ANGLE_surface_d3d_share_handle", which no longer exists. According to the extension spec, the extension was renamed in version 2 to "EGL_ANGLE_surface_d3d_texture_2d_share_handle", but this change was evidently never factored back into GLContextEGL.

Refs:
http://www.khronos.org/registry/egl/extensions/ANGLE/EGL_ANGLE_surface_d3d_texture_2d_share_handle.txt

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

EGL_ANGLE_surface_d3d_share_handle only ever existed in a local patch that we used to have, not in upstream ANGLE.

When I upgraded ANGLE to r653 (bug 657748), I removed this patch as that functionality had been integrated upstream. I didn't notice that the extension name was different.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Fix

Updates extension and relevant identifiers to match spec.
Fixed y-flip problem with shared textures.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Landed on central:
http://hg.mozilla.org/mozilla-central/rev/267ada59f86f

Please give us beta approval.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Landed on aurora and beta.
http://hg.mozilla.org/releases/mozilla-aurora/rev/935e296aabf4
http://hg.mozilla.org/releases/mozilla-beta/rev/0bb77d0b73ad

Comment 5

[Ioana (away)]

Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0

Can anyone please help me with a test case or with STR / guidelines that I can use to verify this fix?

Thank you

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

Actually, no, it's not very easy to verify this one. The only user-visible difference is speed: when we had this bug, running WebGL demos with a large window or full-screen was slower than normal.

In order to prevent this kind of regression in the future, we need WebGL performance tests: bug 676138.

Comment 7

[u279076]

qa- as no QA fix verification needed