674775 - Implement js::IndexToString(cx, uint32_t)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

Upcoming work on using separate storage for element properties (property names which are the string versions of unsigned 32-bit integers) will need to be able to get a string for a given uint32_t, at least as long as jsid can't hold a full 32-bit-integer range of values.  Implement js::IndexToString to support this, and in the absence of users exactly right now, add a JSAPI test that uses private headers to test it.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: h8 hg

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 548980 [details] [diff] [review]
h8 hg

Review of attachment 548980 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/String-inl.h
@@ +206,5 @@
> +inline JSStaticAtom &
> +JSAtom::uintStatic(uint32 u)
> +{
> +    JS_ASSERT(hasUintStatic(u));
> +    return *reinterpret_cast<JSStaticAtom *>(const_cast<JSString::Data *>(intStaticTable[u]));

This casting shold match the casting in JSAtom::intStatic.  Personally, I find this a bit verbose and not terribly informative, but you pick.  I guess you already did :)

Comment 3

[Jeff Walden [:Waldo]]

...or even better: just make the int32 version call the uint32 version.  (With some pre-validity-checking assertions still, of course.)  :-)

Landing shortly...

Comment 4

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/375dba36b860

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/375dba36b860