674835 - RTL articles with previous approved revisions not-RTL don't show up in localization dashboards with the right significance

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P1)

Description

[Scoobidiver (away)]

https://support.mozilla.com/en-US/kb/getting-started-firefox-mobile has been marked as ready for localization, but it doesn't show up in localization dashboards as needing updates:
* https://support.mozilla.com/fr/localization/needing-updates
* https://support.mozilla.com/de/localization/needing-updates
There's no problem in locales where it's not localized:
https://support.mozilla.com/it/localization/untranslated

However, if you try to edit it in the locale, it shows the right English revision:
https://support.mozilla.com/fr/kb/debuter-avec-firefox-mobile/edit

Comment 1

[Scoobidiver (away)]

See also these articles:
* https://support.mozilla.com/en-US/kb/getting-started-firefox
* https://support.mozilla.com/en-US/kb/Deleting%20cookies

Comment 2

[Scoobidiver (away)]

Two more:
* https://support.mozilla.com/en-US/kb/common-questions-after-updating-firefox
* https://support.mozilla.com/en-US/kb/how-do-i-use-bookmarks

Comment 3

[Scoobidiver (away)]

I am unable to see the approval level but I think the latest revision of these articles was a minor change.
The problem is when there was an approved normal change not ready for localization before as in:
https://support.mozilla.com/en-US/kb/Deleting%20cookies/history
The most important approval level of the previous revisions not ready for localization must be taken into account, not only the level of the latest one.

Comment 4

[Kadir Topal [:atopal]]

Indeed. Here is how it should work:

If the latest revision is a 3rd level edit: business as usual

If the latest "ready for L10n" revision is either a minor edit or a second level edit, see if one of the earlier revisions that are approved, but not marked as ready for L10n, are of a higher level edit and use that level on the L10n dashboard.

Also, this should be fixed ASAP, the L10n dashboard loses a lot of functionality as it is.

Comment 5

[[:Cww]]

Wording it a different way: if the latest revision marked RFL isn't translated, display on the l10n dashboard EXCEPT (if that one is trivial AND there are NOT untranslated approved minor/major revisions)

Comment 6

[Erik Rose [:erik][:erikrose]]

Topal: If the ready-for-l10n revision is of trivial significance but there has been a different revision of major significance since the last translation, the thing should be treated as major. Do I infer correctly?

Comment 7

[Kadir Topal [:atopal]]

Yes, absolutely

Comment 8

[Rebecca Billings [:rbillings]]

Verified:
- minor but RTL, in past there was approved major notRTL =show on localization dashboard in major section
- minor but RTL, no approval in history, then not on dashboard
- not translated, minor RTL = shows on 'needs update' dashboard

Comment 9

[Erik Rose [:erik][:erikrose]]

master: http://github.com/jsocol/kitsune/commit/d4188d1a8cfde95bd46aada1101935f853cfa0b5
next: http://github.com/jsocol/kitsune/commit/e0f8e9a852bc6e14f62326281da385dc0b78cfed

Comment 10

[Scoobidiver (away)]

(In reply to Rebecca Billings from comment #8)
> Verified:
> - minor but RTL, in past there was approved major notRTL =show on
> localization dashboard in major section
> - minor but RTL, no approval in history, then not on dashboard
> - not translated, minor RTL = shows on 'needs update' dashboard
It depends on what you name minor.
Some name the three levels: minor, normal, major, others name them: trivial, minor, major.

Comment 11

[Scoobidiver (away)]

(In reply to Rebecca Billings from comment #8)
I guess here minor means level-1 here.
> - not translated, minor RTL = shows on 'needs update' dashboard
'untranslated' section?

Not verified for the following test cases:
* minor RTL, in past there was approved normal not-RTL
* normal RTL, in past there was approved major not-RTL
* normal RTL, no approval in history (non-regression)
* major RTL, no approval in history (non-regression)