675191 - Cached dynamic overlays still get saved to fastload (startup cache)

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[[e-mail]]

When loading cached XUL dynamic overlays the document gets saved to the startup cache even though it had been already put in the startup cache when the overlay was originally cached.

Steps to reproduce problem:
1. Open a XUL document that uses dynamic overlays
2. Close and reopen the document

Expected result: Startup cache written once

Actual result: Startup cache written twice

Additional information:
###!!! ASSERTION: Existing entry in StartupCache.: 'entry == nsnull', file startupcache/StartupCache.cpp, line 298

Presumably the old fastload cache didn't do the check.

Comment 1

[[e-mail]]

Attachment: Proposed patch

We should only set mIsFastLoad if we're actually doing a load. We already do this correctly in the two places where we trigger loads (later on in this method and also in StartDocumentLoad). So the code snippet is bogus.

Comment 2

[[e-mail]]

Pushed changeset ed772265d2bc to mozilla-central.