675215 - CTRL+dragging tab into the bookmarks should get bookmark's title from page title, not the file name

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Sid]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:8.0a1) Gecko/20110729 Firefox/8.0a1
Build ID: 20110729030824

Steps to reproduce:

1. Open http://www.mozilla.com/en-US/firefox/all.html in a tab.
2. Press and hold CTRL, then drag this tab anywhere into bookmarks.


Actual results:

A new bookmark is created with a title "all.html" (from webpage file name).


Expected results:

New bookmark's title should be "Firefox web browser…etc" (from webpage title), as it was before new CTRL+drag bookmarking was implemented.

Comment 1

[Frank Yan (:fryn)]

Attachment: patch

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 549470 [details] [diff] [review]
patch

Better to use browser.contentTitle, since tab.label can contain other cruft.
Also, can you do whatever it takes to fix creating a link on the desktop or in a file manager? I guess the text/html flavor does this. See also gIdentityHandler.onDragStart.

Comment 3

[Frank Yan (:fryn)]

Attachment: patch v2

(In reply to comment #2)
> Also, can you do whatever it takes to fix creating a link on the desktop or
> in a file manager? I guess the text/html flavor does this.

No, text/x-moz-url does this too. I tested dragging to the desktop and Windows Explorer on Windows and to the desktop and Finder on OS X.
Pinning a titled shortcut to the start menu on Windows 7 only works in IE9 though, because they use their proprietary .website-extension-associated type. I'm not sure what the mime type for that is.

Comment 4

[Frank Yan (:fryn)]

Is there a reason why one would use this.tabbrowser.getBrowserForTab(tab) instead of tab.linkedBrowser? AFAICT, the former simply returns the latter.

Comment 5

[Frank Yan (:fryn)]

Oh, we currently can't handle those IE9 shortcuts anyway, so until we fix bug 605222 and bug 624070, it doesn't make sense to include that type.

Comment 6

[Frank Yan (:fryn)]

Pushed to fx-team. Will flip status when merged to m-c.
https://hg.mozilla.org/integration/fx-team/rev/d5c5b7841f21

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/d5c5b7841f21

Comment 8

[Teodosia Pop]

Verified using Mozilla/5.0 (Windows NT 6.1; rv:8.0) Gecko/20100101 Firefox/8.0