675267 - Remove unnecessary target arguments from some event listener manager apis

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Boris Zbarsky [:bzbarsky]]

As far as I can tell, all the callers pass exactly what we have in mTarget.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Try run is http://tbpl.mozilla.org/?tree=Try&rev=b683e4a9e6bf and looks good

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 549425 [details] [diff] [review]
Fix


>     if (document &&
>         (win = document->GetInnerWindow()) && win->IsInnerWindow()) {
>       nsCOMPtr<nsIDOMEventTarget> piTarget(do_QueryInterface(win));
>-      NS_ENSURE_TRUE(piTarget, NS_ERROR_FAILURE);
>-
>-      *aManager = piTarget->GetListenerManager(PR_TRUE);
>-
>-      if (*aManager) {
>-        NS_ADDREF(*aTarget = win);
>-        NS_ADDREF(*aManager);
>-      }
>-      *aDefer = PR_FALSE;
>-    } else {
>-      *aManager = nsnull;
>-      *aTarget = nsnull;
>-      *aDefer = PR_FALSE;
>+      NS_ENSURE_TRUE(piTarget, nsnull);
You could just drop NS_ENSURE_TRUE.
If nsPIDOMWindow doesn't implement nsIDOMEventTarget, something is badly wrong and it is
ok to crash, IMO.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Done.

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c5defc500925

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/c5defc500925